Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Carpenter intel and gnu with intel mpi #942

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Port to Carpenter intel and gnu with intel mpi #942

merged 1 commit into from
Mar 22, 2024

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 21, 2024

PR checklist

  • Short (1 sentence) summary of your PR:
    Port to Carpenter intel and gnu with intel mpi
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Test results as expected, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#740f2a65e055e37bebc81aa25675ebc2a65d735d
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

This PR adds support for two new compiler/mpi options on Carpenter. In addition to Intel, GNU, and Cray compilers with cray-mpich, this adds Intel and GNU support with Intel MPI.

@apcraig apcraig merged commit 12dd204 into CICE-Consortium:main Mar 22, 2024
2 checks passed
DeniseWorthen pushed a commit to DeniseWorthen/CICE that referenced this pull request Apr 13, 2024
@apcraig @DeniseWorthen
Port to Carpenter intel and gnu with intel mpi instead of cray-mpich (C…
bcf5549 
…ICE-Consortium#942)
This was referenced Apr 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@dabail10 dabail10 Awaiting requested review from dabail10

Assignees
No one assigned
Labels
Porting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213